CWE-665: Improper Initialization
Description
The product does not initialize or incorrectly initializes a resource, which might leave the resource in an unexpected state when it is accessed or used.
Submission Date :
April 11, 2008, midnight
Modification Date :
2023-10-26 00:00:00+00:00
Organization :
MITRE
Extended Description
This can have security implications when the associated resource is expected to have certain properties or values, such as a variable that determines whether a user has been authenticated or not.
Example - 1
Here, a boolean initiailized field is consulted to ensure that initialization tasks are only completed once. However, the field is mistakenly set to true during static initialization, so the initialization code is never reached.
// // perform initialization tasks//
...initialized = true;if (!initialized) {}private boolean initialized = true;public void someMethod() {
Example - 2
The following code intends to limit certain operations to the administrator only. If the application is unable to extract the state information - say, due to a database timeout - then the $uid variable will not be explicitly set by the programmer. This will cause $uid to be regarded as equivalent to "0" in the conditional, allowing the original user to perform administrator actions. Even if the attacker cannot directly influence the state data, unexpected errors could cause incorrect privileges to be assigned to a user just by accident.
$uid = ExtractUserID($state);
// # do stuff//
DoAdminThings();$username = GetCurrentUser();$state = GetStateData($username);if (defined($state)) {}if ($uid == 0) {}
Example - 3
The following code intends to concatenate a string to a variable and print the string. This might seem innocent enough, but str was not initialized, so it contains random memory. As a result, str[0] might not contain the null terminator, so the copy might start at an offset other than 0. The consequences can vary, depending on the underlying memory. If a null terminator is found before str[8], then some bytes of random garbage will be printed before the "hello world" string. The memory might contain sensitive information from previous uses, such as a password (which might occur as a result of CWE-14 or CWE-244). In this example, it might not be a big deal, but consider what could happen if large amounts of memory are printed out before the null terminator is found. If a null terminator isn't found before str[8], then a buffer overflow could occur, since strcat will first look for the null terminator, then copy 12 bytes starting with that location. Alternately, a buffer over-read might occur (CWE-126) if a null terminator isn't found before the end of the memory segment is reached, leading to a segmentation fault and crash.
char str[20];strcat(str, "hello world");printf("%s", str);
Related Weaknesses
This table shows the weaknesses and high level categories that are related to this weakness. These relationships are defined to give an overview of the different insight to similar items that may exist at higher and lower levels of abstraction.
CWE-455: Non-exit on Failed Initialization
CWE-456: Missing Initialization of a Variable
CWE-457: Use of Uninitialized Variable
CWE-664: Improper Control of a Resource Through its Lifetime
CWE-770: Allocation of Resources Without Limits or Throttling
CWE-908: Use of Uninitialized Resource
CWE-909: Missing Initialization of Resource
CWE-1188: Initialization of a Resource with an Insecure Default
CWE-1279: Cryptographic Operations are run Before Supporting Units are Ready
CWE-1419: Incorrect Initialization of Resource
Visit http://cwe.mitre.org/ for more details.