CVE-2024-56593
Brcm Fmac Null Pointer Dereference Vulnerability
Description
In the Linux kernel, the following vulnerability has been resolved: wifi: brcmfmac: Fix oops due to NULL pointer dereference in brcmf_sdiod_sglist_rw() This patch fixes a NULL pointer dereference bug in brcmfmac that occurs when a high 'sd_sgentry_align' value applies (e.g. 512) and a lot of queued SKBs are sent from the pkt queue. The problem is the number of entries in the pre-allocated sgtable, it is nents = max(rxglom_size, txglom_size) + max(rxglom_size, txglom_size) >> 4 + 1. Given the default [rt]xglom_size=32 it's actually 35 which is too small. Worst case, the pkt queue can end up with 64 SKBs. This occurs when a new SKB is added for each original SKB if tailroom isn't enough to hold tail_pad. At least one sg entry is needed for each SKB. So, eventually the "skb_queue_walk loop" in brcmf_sdiod_sglist_rw may run out of sg entries. This makes sg_next return NULL and this causes the oops. The patch sets nents to max(rxglom_size, txglom_size) * 2 to be able handle the worst-case. Btw. this requires only 64-35=29 * 16 (or 20 if CONFIG_NEED_SG_DMA_LENGTH) = 464 additional bytes of memory.
INFO
Published Date :
Dec. 27, 2024, 3:15 p.m.
Last Modified :
Jan. 8, 2025, 4:44 p.m.
Source :
416baaa9-dc9f-4396-8d5f-8c081fb06d67
Remotely Exploitable :
No
Impact Score :
3.6
Exploitability Score :
1.8
Public PoC/Exploit Available at Github
CVE-2024-56593 has a 1 public PoC/Exploit available at Github.
Go to the Public Exploits tab to see the list.
References to Advisories, Solutions, and Tools
Here, you will find a curated list of external links that provide in-depth
information, practical solutions, and valuable tools related to
CVE-2024-56593.
We scan GitHub repositories to detect new proof-of-concept exploits. Following list is a collection of public exploits and proof-of-concepts, which have been published on GitHub (sorted by the most recently updated).
None
Results are limited to the first 15 repositories due to potential performance issues.
The following list is the news that have been mention
CVE-2024-56593 vulnerability anywhere in the article.
The following table lists the changes that have been made to the
CVE-2024-56593 vulnerability over time.
Vulnerability history details can be useful for understanding the evolution of a vulnerability, and for identifying the most recent changes that may impact the vulnerability's severity, exploitability, or other characteristics.
-
Initial Analysis by [email protected]
Jan. 08, 2025
Action Type Old Value New Value Added CVSS V3.1 NIST AV:L/AC:L/PR:L/UI:N/S:U/C:N/I:N/A:H Added CWE NIST CWE-476 Added CPE Configuration OR *cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:* versions up to (excluding) 5.4.287 *cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:* versions from (including) 5.5 up to (excluding) 5.10.231 *cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:* versions from (including) 5.11 up to (excluding) 5.15.174 *cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:* versions from (including) 5.16 up to (excluding) 6.1.120 *cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:* versions from (including) 6.2 up to (excluding) 6.6.66 *cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:* versions from (including) 6.7 up to (excluding) 6.12.5 Changed Reference Type https://git.kernel.org/stable/c/07c020c6d14d29e5a3ea4e4576b8ecf956a80834 No Types Assigned https://git.kernel.org/stable/c/07c020c6d14d29e5a3ea4e4576b8ecf956a80834 Patch Changed Reference Type https://git.kernel.org/stable/c/342f87d263462c2670b77ea9a32074cab2ac6fa1 No Types Assigned https://git.kernel.org/stable/c/342f87d263462c2670b77ea9a32074cab2ac6fa1 Patch Changed Reference Type https://git.kernel.org/stable/c/34941321b516bd7c6103bd01287d71a1804d19d3 No Types Assigned https://git.kernel.org/stable/c/34941321b516bd7c6103bd01287d71a1804d19d3 Patch Changed Reference Type https://git.kernel.org/stable/c/67a25ea28f8ec1da8894f2f115d01d3becf67dc7 No Types Assigned https://git.kernel.org/stable/c/67a25ea28f8ec1da8894f2f115d01d3becf67dc7 Patch Changed Reference Type https://git.kernel.org/stable/c/7522d7d745d13fbeff3350fe6aa56c8dae263571 No Types Assigned https://git.kernel.org/stable/c/7522d7d745d13fbeff3350fe6aa56c8dae263571 Patch Changed Reference Type https://git.kernel.org/stable/c/857282b819cbaa0675aaab1e7542e2c0579f52d7 No Types Assigned https://git.kernel.org/stable/c/857282b819cbaa0675aaab1e7542e2c0579f52d7 Patch Changed Reference Type https://git.kernel.org/stable/c/dfb3f9d3f602602de208da7bdcc0f6d5ee74af68 No Types Assigned https://git.kernel.org/stable/c/dfb3f9d3f602602de208da7bdcc0f6d5ee74af68 Patch -
New CVE Received by 416baaa9-dc9f-4396-8d5f-8c081fb06d67
Dec. 27, 2024
Action Type Old Value New Value Added Description In the Linux kernel, the following vulnerability has been resolved: wifi: brcmfmac: Fix oops due to NULL pointer dereference in brcmf_sdiod_sglist_rw() This patch fixes a NULL pointer dereference bug in brcmfmac that occurs when a high 'sd_sgentry_align' value applies (e.g. 512) and a lot of queued SKBs are sent from the pkt queue. The problem is the number of entries in the pre-allocated sgtable, it is nents = max(rxglom_size, txglom_size) + max(rxglom_size, txglom_size) >> 4 + 1. Given the default [rt]xglom_size=32 it's actually 35 which is too small. Worst case, the pkt queue can end up with 64 SKBs. This occurs when a new SKB is added for each original SKB if tailroom isn't enough to hold tail_pad. At least one sg entry is needed for each SKB. So, eventually the "skb_queue_walk loop" in brcmf_sdiod_sglist_rw may run out of sg entries. This makes sg_next return NULL and this causes the oops. The patch sets nents to max(rxglom_size, txglom_size) * 2 to be able handle the worst-case. Btw. this requires only 64-35=29 * 16 (or 20 if CONFIG_NEED_SG_DMA_LENGTH) = 464 additional bytes of memory. Added Reference https://git.kernel.org/stable/c/07c020c6d14d29e5a3ea4e4576b8ecf956a80834 Added Reference https://git.kernel.org/stable/c/342f87d263462c2670b77ea9a32074cab2ac6fa1 Added Reference https://git.kernel.org/stable/c/34941321b516bd7c6103bd01287d71a1804d19d3 Added Reference https://git.kernel.org/stable/c/67a25ea28f8ec1da8894f2f115d01d3becf67dc7 Added Reference https://git.kernel.org/stable/c/7522d7d745d13fbeff3350fe6aa56c8dae263571 Added Reference https://git.kernel.org/stable/c/857282b819cbaa0675aaab1e7542e2c0579f52d7 Added Reference https://git.kernel.org/stable/c/dfb3f9d3f602602de208da7bdcc0f6d5ee74af68
CWE - Common Weakness Enumeration
While CVE identifies
specific instances of vulnerabilities, CWE categorizes the common flaws or
weaknesses that can lead to vulnerabilities. CVE-2024-56593 is
associated with the following CWEs:
Common Attack Pattern Enumeration and Classification (CAPEC)
Common Attack Pattern Enumeration and Classification
(CAPEC)
stores attack patterns, which are descriptions of the common attributes and
approaches employed by adversaries to exploit the CVE-2024-56593
weaknesses.